Fix shadow-inherit, inset-shadow-inherit, drop-shadow-inherit, and text-shadow-inherit#17647
Merged
Merged
Conversation
Contributor
|
@wongjn Mind also fixing this for the other shadow types? https://play.tailwindcss.com/24BUkYoWNi 😬 |
Collaborator
Author
|
Your wish is my command 🫡 |
wongjn
force-pushed
the
fix-shadow-inherit
branch
from
b1d722f to
dfb352f
Compare
philipp-spiess
changed the title
shadow-inheritshadow-inherit, inset-shadow-inherit, drop-shadow-inherit, and text-shadow-inherit
philipp-spiess
approved these changes
Apr 11, 2025
philipp-spiess
left a comment
philipp-spiess
left a comment
Contributor
There was a problem hiding this comment.
Sweeet, thanks man!
| - Ensure the `color-mix(…)` polyfill creates fallbacks for theme variables that reference other theme variables ([#17562](https://github.com/tailwindlabs/tailwindcss/pull/17562)) | ||
| - Fix brace expansion in `@source inline('z-{10..0}')` with range going down ([#17591](https://github.com/tailwindlabs/tailwindcss/pull/17591)) | ||
| - Ensure container query variant names can contain hyphens ([#17628](https://github.com/tailwindlabs/tailwindcss/pull/17628)) | ||
| - Ensure `shadow-inherit`, `inset-shadow-inherit`, `drop-shadow-inherit`, and `text-shadow-inherit` inherits the shadow color ([#17647](https://github.com/tailwindlabs/tailwindcss/pull/17647)) |
Contributor
There was a problem hiding this comment.
Ah turns out it's 4, you added drop-shadow-inherit to that list but fixed it for inset-shadow-inherit. 🙈 I added a test for drop-shadow-inherit 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17643.
This PR completely removes the
color-mix()function forshadow-inherit. This does mean intensity and alpha channel support has been removed when usingshadow-inherit1.With intensity modifiers in #17398, all colors are wrapped in
color-mix(). However, it seemsinheritdoes not work as a value incolor-mix()in Firefox or Chrome (don't have a means to test Safari).Footnotes
While writing this, I noticed other color utilities allow alpha channel modifier syntax for
inherit- do we want to look at removing those too? ↩